Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding information for using TinyMCE editor and FormattedTextareaType with prestashop UI kit and twig form #1308

Merged
merged 1 commit into from Mar 8, 2022
Merged

Adding information for using TinyMCE editor and FormattedTextareaType with prestashop UI kit and twig form #1308

merged 1 commit into from Mar 8, 2022

Conversation

Rizzen59
Copy link
Contributor

Questions Answers
Branch? 1.7.x / 8.x
Description? Please be specific when describing the PR. What did you add, why did you submit it?
Fixed ticket? Fixes #{issue number here} if there is a related issue

@github-actions github-actions bot added the 1.7.x label Feb 26, 2022
@Rizzen59 Rizzen59 changed the title Adding information for using with prestashop UI kit and twig form Adding information for using TinyMCE editor and FormattedTextareaType with prestashop UI kit and twig form Feb 26, 2022
@Rizzen59
Copy link
Contributor Author

I had to seach why my editor was not displayed (I found the solution by looking on Maintenance twig from) so to avoid other developers to loose time. I propose to improove documentation.

matthieu-rolland
matthieu-rolland reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @Rizzen59 👍

matthieu-rolland
matthieu-rolland reviewed Mar 4, 2022
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Rizzen59 !

you need to commit @saulaski 's wording and the PR is good to go 👍

@Rizzen59
Copy link
Contributor Author

Rizzen59 commented Mar 4, 2022

Thanks, i will make the change

@Progi1984 Progi1984 merged commit 5057c5b into PrestaShop:1.7.x Mar 8, 2022
@Progi1984
Copy link
Contributor

Thanks @Rizzen59

Could you create the same PR on 8.x branch ?

@Rizzen59 Rizzen59 deleted the patch-1 branch March 8, 2022 16:56
@matks matks mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland left review comments

@Progi1984 Progi1984 Progi1984 approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@saulaski saulaski saulaski approved these changes

Assignees
No one assigned
Labels
1.7.x Backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Rizzen59 @Progi1984 @matthieu-rolland @NeOMakinG @saulaski @matks