Fix minor typos for Modules section #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leemyongpakvn
commented
Jun 15, 2022
•
leemyongpakvn
commented
| Questions | Answers |
|---|---|
| Branch? | 1.7.x |
| Description? | Correct Bootstrap grid classname + Remove redundant right curly brackets |
smarty only uses single right curly bracket
matthieu-rolland
approved these changes
Jun 15, 2022
NeOMakinG
approved these changes
Jun 16, 2022
MeKeyCool
approved these changes
Jul 4, 2022
|
@leemyongpakvn I guess this needs to be changed into the 8.x doc too? |
|
@NeOMakinG So do I. But I'm not sure about the difference between PS 1.7.x and PS 8.x so I won't touch other more complicated issues in 8.x. By the way, this issue is really minor and just typo so I copied it for 8.x also. |
Yeah that's perfect, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.