Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix old link to https://cs.sensiolabs.org/ #1396

Merged
merged 1 commit into from Jul 4, 2022
Merged

Fix old link to https://cs.sensiolabs.org/ #1396

merged 1 commit into from Jul 4, 2022

Conversation

Sasni
Copy link
Contributor

@Sasni Sasni commented Jun 20, 2022 •
edited by matks

Fix link to PHP CS Fixer

Questions Answers
Branch? 1.7.x
Description? Old link https://cs.sensiolabs.org/ - does not exist.
Fixed ticket? none?

@Sasni
Update _index.md
963d47d 
Fix link to PHP CS Fixer
@github-actions github-actions bot added the 1.7.x label Jun 20, 2022
ghost
ghost approved these changes Jun 21, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you backport you PR in 8.x

@Sasni
Copy link
Contributor Author

Sasni commented Jun 21, 2022

Can you backport you PR in 8.x

Sorry but I don't know how to do this :/

@ghost
Copy link

ghost commented Jun 21, 2022 •
edited by ghost

You have made a PR in the 1.7.x branch
You can do the same in 8.0.x branch
If you don't know how to do it I'll explain

@Sasni
Copy link
Contributor Author

Sasni commented Jun 21, 2022 •
edited

I create this. It is ok?
69d2b70
15dbaf2

@ghost
Copy link

ghost commented Jun 21, 2022

yes

@matks matks changed the title Update _index.md Fix old link to https://cs.sensiolabs.org/ Jul 4, 2022
matks
matks approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I improved a little the PR title

@matks matks merged commit acb58ca into PrestaShop:1.7.x Jul 4, 2022
@Sasni Sasni deleted the patch-1 branch July 4, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeKeyCool MeKeyCool MeKeyCool approved these changes

@matks matks matks approved these changes

@PululuK PululuK PululuK approved these changes

Assignees
No one assigned
Labels
1.7.x Backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sasni @MeKeyCool @matks @PululuK