Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update new-system.md #1783

Merged
merged 1 commit into from Feb 25, 2024
Merged

Update new-system.md #1783

merged 1 commit into from Feb 25, 2024

Conversation

Vots1000
Copy link
Contributor

Changing the order of arguments in the symfony example.

Questions Answers
Branch? 1.7.x / 8.x
Description? Changing the order of arguments for trans() function in the symfony system example.
Fixed ticket?

@Vots1000
Update new-system.md
44c4ee7 
Changing the order of arguments in the symfony example.
@github-actions github-actions bot added the 8.x label Feb 25, 2024
kpodemski
kpodemski approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! We indeed have a different parameters order here and inside ModuleFrontController 😅

@kpodemski kpodemski merged commit 8ef1dbe into PrestaShop:8.x Feb 25, 2024
1 check passed
@kpodemski
Copy link
Contributor

thanks @Vots1000 :)

@Vots1000 Vots1000 deleted the patch-1 branch February 26, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

Assignees
No one assigned
Labels
8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vots1000 @kpodemski