New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email theme generation documentation #269
Conversation
weight: 2 | ||
--- | ||
|
||
# The Email Theme component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make more sense to call it Mail Template component
to follow same naming that is in code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would we logical from a developper perspective, but the page in the back office is named "Email theme" so I thought matching with this would be more "user friendly"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the word "template" is a bit confusing in this situation, I had to add a section Vocabulary
in this doc to avoid confusion between layout and template.. not really easy to find correct and clear naming on this feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's developer documentation, so calling same component in different names is weird imo. It's the same as calling Grid component
in code, but List component
in docs.
Please consider moving the tutorials to the Modules section |
That's fine for me, but I don't know in which subpart I could put it. The architecture of the modules section isn't very clear. And although this doc contains some examples about extending the themes via a module there are also more generic info about the generator. Which will be probably extended when the feature is improved (configurable theme for example, along with how you set their configuration). |
@eternoendless Alright I moved the tutorials in the module section, the workflow and feature is still in the Components section, this seemed more logical to me. |
…n module installation
… theme generation tutorial
Introduce documentation about the "Email theme" component
Fixes #208