Finish detailing product form types along with commands #558
Conversation
| | **PriceType** | `price` | Contains data about pricing | `UpdateProductPriceCommand` | | ||
| | **SpecificPriceType** | `add_specific_price` | Component to add a specific price | `AddProductSpecificPriceCommand` | | ||
| | **SpecificPricePriorityType** | `specific_price_priority` | Contains data about the priority order for specific prices | `UpdateSpecificPricePriorityCommand` | | ||
| | **StockType** | `stock` | Contains data about the product stock | `UpdateProductStockCommand` `UpdateProductWarehouseLocationCommand` (TBD should it be managed in stock form or separately) | |
There was a problem hiding this comment.
UpdateProductWarehouseLocationCommand there is still some logic related to warehouses ?
There was a problem hiding this comment.
It seems to be still managed, I guess it is for backward compatibility because some Modules use it Just like advanced shop management It would be nice to have some sample modules to test this feature
| | **BasicInformationType** | `basic` | Contains the basic product information of the Product | `AddProductCommand` and `UpdateProductBasicInformationCommand` | | ||
| | **DescriptionType** | `description` | Contains the description of the Product | `UpdateProductBasicInformationCommand` | | ||
| | **ShortcutType** | `shortcut` | Contains shortcut for prices, quantity and reference of the Product | `UpdateProductPriceCommand`, `UpdateProductStockCommand` and `UpdateProductOptionsCommand` | | ||
| | **TypeaheadProductPackCollectionType** | `pack_items` | List of products (for Pack of product) | `UpdateProductPackCommand` `CleanProductFromPackCommand` | |
There was a problem hiding this comment.
There is no update action for a pack, we can only remove the packed product, so i would say:
- AddProductToPackCommand (UpdateProductPackCommand PrestaShop#19827)
- RemoveProductFromPackCommand
There was a problem hiding this comment.
If we want some improvements, we could also add additional command like UpdatePackedProductQuantityCommand
There was a problem hiding this comment.
Just a note to close this discussion.
As discussed in slack, implemented UpdateProductPackCommand which resets the packs association completely to a new provided pack.
|
Hello, I have modified your PR to target the We have modified the devdocs inner working in order to welcome multiple documentation versions. This is because soon we will have a 1.7 documentation and a 8.0 documentation, matching PrestaShop 1.7 or PrestaShop 8.0 softwares. Read more on https://devdocs.prestashop.com/1.7/contribute/documentation/how/documentation-versions/ Please also note that now that we have multiple versions inside one documentation, we had to build a workflow that can handle this setup. This repository https://github.com/PrestaShop/docs now only contains the content of the documentation, and https://github.com/PrestaShop/devdocs-site contains the sources and the deployment workflow. Because of this, some files have moved and you might have to rebase your Pull Request to match the new structure of the repository. |
|
Hi @jolelievre Could you or someone else working on the product page take on this PR and finish it? |
|
Hi @jolelievre Is this PR still relevant? |
Finish detailing product form types along with commands