Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths for ref and relref shortcodes to have anchors in generated html-files. #693

Merged
merged 5 commits into from Aug 31, 2020

Conversation

likemusic
Copy link
Contributor

Questions Answers
Description? Fix paths for ref and relref shortcodes to have anchors in generated html-files.
Fixed ticket? Fixes #692

This PR includes:

  • remove .md ends in all ref and relref paths;
  • paths ends /_index.md replaces to just / (because paths ending /_index generates error REF_NOT_FOUND);

This PR doesn't introduce any new broken links. To check this I scan devdoc in master and this PR branches by Xenu. There is scan results screenshots:

  • for this PR branch:
    image

  • for master-branch:
    image

Xenu scan result files in attaches:
links-anchors.zip
master.zip

@Progi1984
Copy link
Contributor

@PierreRambaud I'm not sure with this PR. What do you think about it ?

@PierreRambaud
Copy link
Contributor

@PierreRambaud I'm not sure with this PR. What do you think about it ?

It's ok regarding https://gohugo.io/content-management/cross-references/

@Progi1984
Copy link
Contributor

Thanks ;) @PierreRambaud

@NeOMakinG NeOMakinG merged commit a1ed873 into PrestaShop:master Aug 31, 2020
@NeOMakinG
Copy link

Thanks @likemusic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links generated without anchors.
5 participants