Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined index, fix form headings #155

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Dec 2, 2022

Questions Answers
Description? Read below
Type? bug fix / refacto
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#30221
How to test? Generate sitemap and see that no notices are thrown and the config form looks somehow OK.

Changes

  • Error about directory not being writeable is shown by notification, not generated manually. I used context error notifications for this.
  • Fixed panel headings by using proper syntax. It should be a div panel-heading, not a h3. Fixes a tiny bug.
    Snímek obrazovky 2022-12-03 142813
  • Fixed notices where it was trying to access [0] on a boolean. Simmilar fix was applied for products, but not for categories.

@kpodemski kpodemski added this to the 4.2.1 milestone Dec 6, 2022
Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hlavtox

Thank you for your PR, I tested it on 1.7.8.7, 8.0.X and develop and it works, as we can see here :

Untitled_.Dec.7.2022.3_00.PM.webm

@kpodemski kpodemski merged commit 7f0bc37 into PrestaShop:dev Dec 7, 2022
@kpodemski
Copy link
Contributor

Thanks @Hlavtox :)

@Hlavtox Hlavtox deleted the modernize branch July 26, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google sitemap Cron job is not generated and throws Exception
4 participants