Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style subcategories, sitemap, stores #111

Merged
merged 6 commits into from Nov 16, 2021
Merged

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Nov 10, 2021

Will close:
#84
#83

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 11, 2021

@NeOMakinG done man

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 11, 2021

@NeOMakinG

I also improved store page more, cleaner markup, used BS classes, styled the collapse things and stuff, image made responsive etc

Výstřižek

@Hlavtox Hlavtox changed the title Style subcategories Style subcategories and improve stores Nov 11, 2021
@Hlavtox Hlavtox changed the title Style subcategories and improve stores Style subcategories, sitemap, stores Nov 11, 2021
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 11, 2021

Sitemap done

sitemap

src/scss/partials/_helpers.scss Outdated Show resolved Hide resolved
templates/catalog/_partials/subcategories.tpl Outdated Show resolved Hide resolved
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 15, 2021

@NeOMakinG should be good now man

@NeOMakinG NeOMakinG merged commit 03dd2c2 into PrestaShop:develop Nov 16, 2021
@NeOMakinG
Copy link
Contributor

Thanks @Hlavtox 🙏

rodriciru pushed a commit to rodriciru/hummingbird that referenced this pull request Nov 17, 2021
Style subcategories, sitemap, stores
@SharakPL
Copy link
Contributor

@media screen and (min-width: 576px) {
.container--limited-sm {
max-width: 540px;
}
}
@media screen and (min-width: 768px) {
.container--limited-md {
max-width: 720px;
}
}
@media screen and (min-width: 992px) {
.container--limited-lg {
max-width: 960px;
}
}
@media screen and (min-width: 1200px) {
.container--limited-xl {
max-width: 1140px;
}
}

@Hlavtox I'm preparing PR to remove these. Any reason why did you add these instead of using BS defaults container-sm, container-md etc. which are exactly the same?

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jun 21, 2022

@SharakPL They work different, I want to limit the page width. See:
https://getbootstrap.com/docs/5.1/layout/containers/

@SharakPL
Copy link
Contributor

OK, I get it. I'll just try to improve it a bit...

@SharakPL
Copy link
Contributor

#325
In case grid sizes ever change this won't need updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants