-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New webpack config #67
Conversation
@Oksydan just remove swiper related things, we won't use it, it was a miss. You need to add Overwise it looks fine to me, made me remember that we should split page-related bundles and find a way to import these on every single pages |
We've a problem, looks like fonts are not anymore loading, there should be a miss with css-loader or font-loader I think so |
@NeOMakinG I had added you feedback to problems list. |
@Oksydan publicPath is not defined, not using .env file |
@Hlavtox yes, since publicPath is defined inside env file it will be undefined. |
@Oksydan Can we hardcode "../" when only wanting to build the assets? It works fine otherwise, except the fonts and img paths. :-) |
I think that would be a thing yes, informing is the key |
When you build it and check theme.css, it builds the paths like The paths must be relative or it won't work in different subfolder or theme folder. |
if you have a shop in the subfolder, you need to define a different public path, and that's it, this is why @Oksydan is using Scenario
It's a matter of having proper You also have the possibility to create a bundle with overridden |
I didn't test this yet, I need to do it today in order to confirm that this works with a vhost and without, that's it :p |
@kpodemski So everyone who wants to use this theme needs to configure his build environment and build it? WTF :D How do you want to distribute it? |
that's a good point. I was thinking from the developer perspective |
@NeOMakinG it is't going to work w/o vhost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New webpack config
npm run build
,npm run watch
/npm run dev
are working but I am not done with it yet.I am going to test it and fix some issues.
Known issues:
@NeOMakinG It is working and compiling you are able to test it atm and provide some feedback.
To make it working copy
.env-example
and create.env
in the same directory. Fill values depending on your local prestashop installation.