Fix order customer comment and product out of stock

[jolelievre]

Questions	Answers
Description?	Some templates had been fixed directly in the core but not in the sources from this repo Also update composer dependencies so that PHP 7.3 can be used to generate the mail theme
Type?	improvement
BC breaks?	yes
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#22028
How to test?	You can regenerate the modern theme with the appropriate wordings (already tested by @jolelievre )

[eternoendless]

@jolelievre Would you mind pushing your last commit in a separate PR?

[PierreRambaud]

Could you please separate commits?

[jolelievre]

You mean update the dependency in a separate PR?

[PierreRambaud]

You mean update the dependency in a separate PR?

Yep :)

[jolelievre]

Ok @PierreRambaud I split the update into this PR #10

And @Julievrz I made the modification to use the existing wording, so I added the Product line so that the merchant can still identify which product is concerned To answer your question two templates exist one is used by the core and another one by the module ps_emailalert I guess this one has been integrated in the core directly later 🤷‍♂️

[ghost]

@jolelievre my last PR #8 deleted

{{ 'Hi {firstname} {lastname},'|trans({}, 'Emails.Body', locale) }}

Because it's an email for the shop not for the customer.

[ghost]

Here it's also an email for the shop :

https://github.com/PrestaShop/mjml-theme-converter/blob/master/mails/themes/modern_mjml/core/productoutofstock.mjml.twig#L12

Clicked too fast 😅

[Julievrz]

The wording looks good to me, but I could not find the label. ✔️

[atomiix]

As @okom3pom said, this email is for the shop, not the customer.

Suggested change

	{{ 'Hi {firstname} {lastname},'|trans({}, 'Emails.Body', locale) }}
	{{ 'Hi,'|trans({}, 'Emails.Body', locale) }}

[sowbiba]

LGTM
Waiting to resolve @atomiix and @okom3pom feedback to validate

[matthieu-rolland]

LGTM for me too once @atomiix 's feedback has been dealt with.

[Progi1984]

Some feedbacks

[jolelievre]

@Progi1984 @atomiix You're both right, I was just lazy updating my global config 😅
It's done now and I removed the commit from the PR

.

[sarahdib]

@jolelievre this one can be tested by a dev :)

[atomiix]

Thanks @jolelievre