Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make committer applications process lighter #101

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Make committer applications process lighter #101

merged 3 commits into from
Jun 22, 2022

Conversation

matks
Copy link
Contributor

@matks matks commented Jun 8, 2022

Questions Answers
Description Make committer applications process lighter. See the context in #100
Fixed ticket Fixes #100

@matks
Copy link
Contributor Author

matks commented Jun 9, 2022

I added 5c3b8d2 following a feedback from @kpodemski

eternoendless
eternoendless reviewed Jun 14, 2022
View reviewed changes
content/maintainers-guide/how-to-become-a-committer.md Outdated
3. Once all questions have been answered, current maintainers vote.
4. If the simple majority of positive votes is achieved, the new committer is approved.
2. If three maintainers approve the application, the new committer is approved.
3. After one week, if the issue did not receive three positive votes, it is considered rejected and closed.
Copy link
Member

@eternoendless eternoendless Jun 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One week might be too short (eg. if people are too busy or on vacation)

What about 15 or 30 days?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30 days then

@matks
Apply suggestions from code review
4ca580d 
Co-authored-by: Pablo Borowicz <pablo.borowicz@prestashop.com>
@NeOMakinG
Copy link

It looks even too formal for me, that's something we could do in one click by discussing with maintainers, even if the contributor doesn't want

  • Notice the fact that someone is active on code review, providing good quality comments
  • Discuss with the team : Should we add it to the committer group?
  • If most are ok with it, just send an invite and let the community contributor free to accept or not

Why do we need to make the process that hard? It's a simple group giving some review/assign rights, that's it, nothing big :)

@eternoendless
Copy link
Member

Yeah, I think the written submission shouldn't be strictly necessary, but it needs to remain an option if the initiative doesn't come from a maintainer.

eternoendless
eternoendless approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@eternoendless eternoendless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The process can be improved further, but this is good enough for me

@eternoendless eternoendless merged commit 67fd3f9 into PrestaShop:master Jun 22, 2022
@matks matks deleted the easy-committer branch June 28, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternoendless eternoendless eternoendless approved these changes

@kpodemski kpodemski kpodemski approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lighten the committer application process
4 participants
@matks @NeOMakinG @eternoendless @kpodemski