Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify minimum PrestaShop version for constants #37

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Specify minimum PrestaShop version for constants #37

merged 2 commits into from
Sep 29, 2020

Conversation

Quetzacoalt91
Copy link
Member

Questions Answers
Description? This PRs allow the proper constants to be defined, depending on the PrestaShop version associated with PHPStan
Type? improvement
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #36
How to test? cd tests/modules_samples/constant_check && bash run.sh

@Quetzacoalt91 Quetzacoalt91 merged commit d806112 into PrestaShop:master Sep 29, 2020
@Quetzacoalt91 Quetzacoalt91 deleted the add-minimum-version-for-const branch September 29, 2020 16:25
@Quetzacoalt91
Copy link
Member Author

Thanks for the review @PierreRambaud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define constants when supposed to be existing in core
2 participants
@Quetzacoalt91 @PierreRambaud