Add new rule to add visibility for only method and property inside a …

[PoulainMaxime]

…class

Questions	Answers
Description?	Adding new rule for set visibility only for method and properties. We disabled this rule only for 'const' case
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?
How to test?	Remove keyword public for method or property and run csfixer, he should add the missing keyword
Possible impacts?	none

[matks]

Hello @PoulainMaxime that is a very good idea

but this means that if we merge this, any module using php-dev-tools will see their CI go red if they have not prefixed every const with a clear scope, right?

[Quetzacoalt91]

Hi @matks,

When you disable the rule for a specific case, it does not check it anymore. This means that whatever you have (with visibility or without it), it won't report anything.
=> No CI will go red with this update of rule if they already applied it on consts before.

[matks]

Hi @matks,

When you disable the rule for a specific case, it does not check it anymore. This means that whatever you have (with visibility or without it), it won't report anything. => No CI will go red with this update of rule if they already applied it on consts before.

Then I approve it 😄

[PoulainMaxime]

Hi @matks,
When you disable the rule for a specific case, it does not check it anymore. This means that whatever you have (with visibility or without it), it won't report anything. => No CI will go red with this update of rule if they already applied it on consts before.

Then I approve it 😄

Hi @matks, if everything is good, is it possible to merge it? Thanks !

[atomiix]

The PR seems good but, why? 😅 Can you explain why you're disabling the rule to force to set the visibility for const?

[matks]

Can you explain why you're disabling the rule to force to set the visibility for const?

I guess it's because a lot of php developers do not prefix consts by visibility 😅

[Quetzacoalt91]

We actually have another reason than habits. :)

PS Facebook is reported to fail of early versions of PS 1.7 (reported by @eternoendless earlier this month). This was PHP-Parser (with PREFER_PHP7 flag) in the core unable to read the code after this rule being applied.
We made the change to improve the compatibility of all modules with PrestaShop 1.7.x.

[Quetzacoalt91]

Sorry for being pushy, but is there anything I can do to go on the review?
When released, the change would be made on the validator as well. At the moment it still asks the public to be added in front of constants, and I'd like to avoid that if it breaks early versions on PrestaShop 1.7.

Thanks

[matks]

PR looks good to me 👍 @atomiix do you have some last worries or is it OK?

[matks]

Thank you @atomiix @PoulainMaxime and @Quetzacoalt91