-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specs for the order status page #207
Conversation
marionf
commented
Feb 16, 2021
•
edited
Loading
edited
Questions | Answers |
---|---|
Description? | Add mutlistore specs & modal deletion to the order status page & add specs for listing |
back-office/shop-parameters/order-settings/order-setting-statuses-page.md
Outdated
Show resolved
Hide resolved
|
||
When **adding a new order status or editing an order status**, the user can fulfill the information below: | ||
* **Status name**, mandatory information | ||
* **Icon**. (to be removed after migration since it is not used anymore), | ||
* **Label color** with a color picker or write the hexadecimal code | ||
* **Color** with a color picker or write the hexadecimal code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should happen when the color field is left blank ? (maybe it's out of scope for this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the default value of the field: #ffffff
There is an issue when the color is not defined: PrestaShop/PrestaShop#21284 (same issue in the order status listing)
I linked the issue, the behavior in this case is still to be defined
**Adding or Editing a return status** allows the user to add or edit **the status name** input text on any back-office language and **the label color** with a color picker or directly into the input text with the hexadecimal code. | ||
### Add / edit order return status | ||
|
||
**Adding or Editing an order return status** allows the user to add or edit **the order return status name** input text on any back-office language and **the label color** with a color picker or directly into the input text with the hexadecimal code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should happen when the color field is left blank ? (maybe it's out of scope for this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the default value of the field: #ffffff
There is an issue when the color is not defined: PrestaShop/PrestaShop#21284 (same issue in the order return status listing)
I linked the issue, the behavior in this case is still to be defined
|
||
4) Send email to the customer | ||
|
||
The merchant can choose to send an email or not to the customer when the order status is applied to the order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If no mail template is selected for the status, should the merchant still be able to change the "Send email" setting to Yes ? (Currently, doing this will cause an error on an order if the status is changed to the status with "Send mail" to "Yes" and no template)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it should not, we need to specify the behavior + maybe a message in this case
Do you know if there is an issue for that ? I can link it to the specs but I didn't find any issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done here: 76c9687
…ses-page.md Co-authored-by: Robin-Fischer-PS <55688534+Robin-Fischer-PS@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me :)