Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for the order status page #207

Merged
merged 7 commits into from
Apr 8, 2021
Merged

Add specs for the order status page #207

merged 7 commits into from
Apr 8, 2021

Conversation

marionf
Copy link
Contributor

@marionf marionf commented Feb 16, 2021

Questions Answers
Description? Add mutlistore specs & modal deletion to the order status page & add specs for listing

@marionf marionf added Review required Specifications to be reviewed Waiting for PM Waiting for PM review Waiting for QA Waiting for QA review labels Feb 16, 2021
@marionf marionf changed the title Add mutlistore specs to order status page Add specs for the order status page Feb 16, 2021

When **adding a new order status or editing an order status**, the user can fulfill the information below:
* **Status name**, mandatory information
* **Icon**. (to be removed after migration since it is not used anymore),
* **Label color** with a color picker or write the hexadecimal code
* **Color** with a color picker or write the hexadecimal code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should happen when the color field is left blank ? (maybe it's out of scope for this PR)

Copy link
Contributor Author

@marionf marionf Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the default value of the field: #ffffff
There is an issue when the color is not defined: PrestaShop/PrestaShop#21284 (same issue in the order status listing)
I linked the issue, the behavior in this case is still to be defined

**Adding or Editing a return status** allows the user to add or edit **the status name** input text on any back-office language and **the label color** with a color picker or directly into the input text with the hexadecimal code.
### Add / edit order return status

**Adding or Editing an order return status** allows the user to add or edit **the order return status name** input text on any back-office language and **the label color** with a color picker or directly into the input text with the hexadecimal code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should happen when the color field is left blank ? (maybe it's out of scope for this PR)

Copy link
Contributor Author

@marionf marionf Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the default value of the field: #ffffff
There is an issue when the color is not defined: PrestaShop/PrestaShop#21284 (same issue in the order return status listing)
I linked the issue, the behavior in this case is still to be defined


4) Send email to the customer

The merchant can choose to send an email or not to the customer when the order status is applied to the order.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no mail template is selected for the status, should the merchant still be able to change the "Send email" setting to Yes ? (Currently, doing this will cause an error on an order if the status is changed to the status with "Send mail" to "Yes" and no template)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it should not, we need to specify the behavior + maybe a message in this case
Do you know if there is an issue for that ? I can link it to the specs but I didn't find any issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here: 76c9687

@Robin-Fischer-PS Robin-Fischer-PS added Waiting for author Waiting for author feedback and removed Waiting for QA Waiting for QA review labels Mar 4, 2021
marionf and others added 3 commits March 4, 2021 16:20
…ses-page.md

Co-authored-by: Robin-Fischer-PS <55688534+Robin-Fischer-PS@users.noreply.github.com>
@marionf marionf removed the Waiting for author Waiting for author feedback label Mar 8, 2021
Copy link
Contributor

@Robin-Fischer-PS Robin-Fischer-PS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me :)

@marionf marionf merged commit 04f69af into master Apr 8, 2021
@marionf marionf deleted the marionf-patch-5 branch April 8, 2021 08:42
@marionf marionf removed the Waiting for PM Waiting for PM review label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review required Specifications to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants