Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags specs #268

Merged
merged 22 commits into from
Nov 30, 2021
Merged

Tags specs #268

merged 22 commits into from
Nov 30, 2021

Conversation

Saimis777
Copy link
Contributor

Questions Answers
Description? Please be specific when describing the PR. What did you add, why did you submit it?
Fixed ticket? Fixes #{issue number here} if there is a related issue

marionf
marionf suggested changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@marionf marionf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let you see my comments and suggestions, let me know if you have questions

@marionf marionf added the Waiting for author Waiting for author feedback label Nov 22, 2021
Saimis777 and others added 3 commits November 23, 2021 17:32
@Saimis777 @marionf
Update content/1.7/back-office/shop-parameters/search/tags/tags-listi…
f805407 
…ng.md

Co-authored-by: marionf <marionf@users.noreply.github.com>
@Saimis777 @marionf
Update content/1.7/back-office/shop-parameters/search/tags/add-edit-t…
425aeb4 
…ag.md

Co-authored-by: marionf <marionf@users.noreply.github.com>
@Saimis777
Update tags-listing.md
b878694
Saimis777 and others added 3 commits November 25, 2021 10:29
@Saimis777 @marionf
Update content/1.7/back-office/shop-parameters/search/tags/tags-listi…
916a9fc 
…ng.md

Co-authored-by: marionf <marionf@users.noreply.github.com>
@Saimis777 @marionf
Update content/1.7/back-office/shop-parameters/search/tags/tags-listi…
8f5fd14 
…ng.md

Co-authored-by: marionf <marionf@users.noreply.github.com>
@Saimis777
Update tags-listing.md
e011439
@marionf marionf added PM ✔️ Check done, spec approved Waiting for QA Waiting for QA review and removed Waiting for author Waiting for author feedback labels Nov 25, 2021
@marwachelly marwachelly self-assigned this Nov 29, 2021
@marwachelly marwachelly added Waiting for author Waiting for author feedback and removed Waiting for QA Waiting for QA review labels Nov 29, 2021
Saimis777 and others added 3 commits November 30, 2021 09:41
@Saimis777 @marionf
Update content/1.7/back-office/shop-parameters/search/tags/tags-listi…
1c06d24 
…ng.md

Co-authored-by: marionf <marionf@users.noreply.github.com>
@Saimis777 @marionf
Update content/1.7/back-office/shop-parameters/search/tags/tags-listi…
f2ad102 
…ng.md

Co-authored-by: marionf <marionf@users.noreply.github.com>
@Saimis777 @marionf
Update content/1.7/back-office/shop-parameters/search/tags/tags-listi…
545b79a 
…ng.md

Co-authored-by: marionf <marionf@users.noreply.github.com>
@marionf marionf removed the Waiting for author Waiting for author feedback label Nov 30, 2021
marwachelly
marwachelly approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@marwachelly marwachelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Can be merged. Thanks @marionf , @Saimis777

@marwachelly marwachelly added the QA ✔️ Spec approved by QA label Nov 30, 2021
@marionf marionf merged commit 297cdbf into master Nov 30, 2021
@marionf marionf deleted the tags-specs branch November 30, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marionf marionf marionf approved these changes

@marwachelly marwachelly marwachelly approved these changes

Assignees

@marwachelly marwachelly

Labels
PM ✔️ Check done, spec approved QA ✔️ Spec approved by QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saimis777 @marionf @marwachelly