Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect display_taxes_label setting when showing amount #51

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Respect display_taxes_label setting when showing amount #51

merged 3 commits into from
Oct 29, 2021

Conversation

tswfi
Copy link
Contributor

@tswfi tswfi commented Oct 13, 2021

Questions Answers
Description? Respect display taxes label setting when showing the total price
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#26237.
How to test? Make sure you have one country that has display_taxes_label on and another one that has if off. Check the payment step with ps_checkpayment as the payment method and check that the "(tax incl.)" text is not shown on the country that has the display taxes label setting off.

matks
matks previously approved these changes Oct 14, 2021
View reviewed changes
@matks matks added the waiting for QA Status: Waiting for QA feedback label Oct 14, 2021
@matks matks mentioned this pull request Oct 14, 2021
Closed
@florine2623 florine2623 self-assigned this Oct 25, 2021
atomiix
atomiix previously approved these changes Oct 26, 2021
View reviewed changes
@florine2623
Copy link
Contributor

Hello @tswfi ,

Thanks for the PR !
It's all good to me ✅

@florine2623 florine2623 added QA ✔️ and removed waiting for QA Status: Waiting for QA feedback labels Oct 28, 2021
@Progi1984
Copy link
Member

@tswfi Could you rebase your PR ?

@tswfi
Copy link
Contributor Author

tswfi commented Oct 28, 2021

@tswfi Could you rebase your PR ?

rebased

Progi1984
Progi1984 previously approved these changes Oct 28, 2021
View reviewed changes
@Progi1984 Progi1984 closed this Oct 28, 2021
@Progi1984 Progi1984 reopened this Oct 28, 2021
@tswfi
Copy link
Contributor Author

tswfi commented Oct 28, 2021

Whoops, should never rebase blind :)

@tswfi
Copy link
Contributor Author

tswfi commented Oct 28, 2021

@Progi1984 wanna restart the workflows again, thanks and sorry.

@Progi1984 Progi1984 merged commit 5903aca into PrestaShop:dev Oct 29, 2021
@Progi1984
Copy link
Member

Thanks @tswfi & @florine2623

@Progi1984 Progi1984 added this to the 2.0.6 milestone Oct 29, 2021
@tswfi tswfi deleted the respect_display_taxes branch October 29, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks Awaiting requested review from matks

@atomiix atomiix Awaiting requested review from atomiix

Assignees

@florine2623 florine2623

Labels
QA ✔️
Projects
None yet
Milestone
2.0.6
Development

Successfully merging this pull request may close these issues.

Respect "Display tax label" setting in ps_checkpayment
5 participants
@tswfi @florine2623 @Progi1984 @atomiix @matks