Update templates to reflect changes in classic theme #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ziegenberg
commented
Jun 19, 2020
ziegenberg
commented
| Questions | Answers |
|---|---|
| Description? | Update templates to reflect changes in classic theme |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/Prestashop#{no issue}. |
| How to test? | Please check in the nav, footer and the contact us page, that all detail is shown as in the classic theme. |
…ction Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
…tinfo/nav.tpl Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
…tinfo/ps_contactinfo.tpl Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
…tinfo/ps_contactinfo-rich.tpl Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
update-template-to-reflect-changes-in-classic-theme
branch
from
01c7a97
to
4ec97b9
Compare
|
I rebased this PR onto the branch from #36, so it should be merge first. |
PierreRambaud
approved these changes
Jun 22, 2020
NeOMakinG
approved these changes
Jun 22, 2020
|
Hello @ziegenberg, thanks for your PR. If I understand correctly, we need to check that all the blocks you listed (nav, footer, contact-us) are still displayed correctly, like before the modification ? Thank you in advance. |
|
@SimonGrn yes, that's about right. This PR updates this pluings templates to the ones used integrated in ps core. So the design might change slightly. |
|
Thanks @ziegenberg & @sarahdib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.