Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new hooks for the contact page #49

Merged
merged 3 commits into from Nov 10, 2022
Merged

Add new hooks for the contact page #49

merged 3 commits into from Nov 10, 2022

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Sep 2, 2022 •
edited

Questions Answers
Description? We want to move widgets to regular hooks to make life easier for theme developers
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#29198.
Related PR PrestaShop/classic-theme#52
How to test? Verify that the contact page is working properly. Make sure to test with PrestaShop/classic-theme#52
Possible impacts? Contact page display

@NeOMakinG NeOMakinG marked this pull request as ready for review September 2, 2022 12:47
@NeOMakinG NeOMakinG changed the title Change contact page widget to hooks Add new hooks for the contact page Sep 2, 2022
matks
matks reviewed Sep 2, 2022
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little improvement to ease readability 😄

ps_contactinfo.php Outdated Show resolved Hide resolved
@NeOMakinG NeOMakinG requested a review from matks September 5, 2022 05:41
@matks matks mentioned this pull request Sep 28, 2022
Merged
@matks matks mentioned this pull request Oct 9, 2022
Merged
@hibatallahAouadni hibatallahAouadni self-assigned this Oct 12, 2022
hibatallahAouadni
hibatallahAouadni approved these changes Nov 10, 2022
View reviewed changes
Copy link

@hibatallahAouadni hibatallahAouadni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @NeOMakinG

Thanks for your PR 🚀
LGTM, QA ✔️

Thanks!

@matks
Copy link
Contributor

matks commented Nov 10, 2022

Thank you @NeOMakinG

@matks matks merged commit 15cf2a6 into PrestaShop:dev Nov 10, 2022
@matks matks added this to the 3.3.1 milestone Nov 10, 2022
@hibatallahAouadni hibatallahAouadni mentioned this pull request Nov 10, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@hibatallahAouadni hibatallahAouadni hibatallahAouadni approved these changes

Assignees

@hibatallahAouadni hibatallahAouadni

Labels
QA ✔️
Projects
None yet
Milestone
3.3.1
3 participants
@NeOMakinG @matks @hibatallahAouadni