Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contact page hooks #29516

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Add contact page hooks #29516

merged 1 commit into from
Nov 10, 2022

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Sep 2, 2022 •
edited by matks
Loading

Questions Answers
Branch? develop
Description? We need to add some new hook for the contact page instead of using widgets
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #29198.
Related PRs PrestaShop/hummingbird#366 , PrestaShop/ps_contactinfo#49 , PrestaShop/classic-theme#52
How to test? Can be tested with every related PRs, the contact page should be working as expected
Possible impacts? Contact page

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Sep 2, 2022
@NeOMakinG NeOMakinG marked this pull request as ready for review September 2, 2022 12:47
@NeOMakinG NeOMakinG requested a review from a team as a code owner September 2, 2022 12:47
kpodemski
kpodemski approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm accepting, but it'll need an autoupgrade PR too.

@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Oct 9, 2022
@hibatallahAouadni hibatallahAouadni self-assigned this Oct 12, 2022
hibatallahAouadni
hibatallahAouadni approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@hibatallahAouadni hibatallahAouadni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @NeOMakinG

Thanks for your PR 🚀
LGTM, QA ✔️

Thanks!

@hibatallahAouadni hibatallahAouadni added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 10, 2022
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@matks
Copy link
Contributor

matks commented Nov 10, 2022

Thank you @NeOMakinG

@matks matks added this to the 8.1.0 milestone Nov 10, 2022
@matks matks merged commit c6fbab3 into PrestaShop:develop Nov 10, 2022
@hibatallahAouadni hibatallahAouadni mentioned this pull request Nov 10, 2022
Closed
2 tasks
@kpodemski kpodemski added the Needs documentation Needs an update of the developer documentation label Jan 23, 2023
@kpodemski kpodemski mentioned this pull request Jan 26, 2023
Closed
28 tasks
@kpodemski kpodemski added Documentation ✔️ Developer documentation is up-to-date and removed Needs documentation Needs an update of the developer documentation labels Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

@matks matks matks approved these changes

@hibatallahAouadni hibatallahAouadni hibatallahAouadni approved these changes

@yanmakouf yanmakouf yanmakouf approved these changes

Assignees

@hibatallahAouadni hibatallahAouadni

Labels
develop Branch Documentation ✔️ Developer documentation is up-to-date Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

Remove all hardcoded widgets from theme
6 participants
@NeOMakinG @prestonBot @matks @kpodemski @hibatallahAouadni @yanmakouf