Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send voucher code, when user sign up account #38

Merged
merged 1 commit into from
Sep 6, 2019
Merged

send voucher code, when user sign up account #38

merged 1 commit into from
Sep 6, 2019

Conversation

toar86
Copy link
Contributor

@toar86 toar86 commented Jul 24, 2019

send voucher code, when user sign up account

send voucher code, when user sign up account
@PierreRambaud PierreRambaud changed the base branch from master to dev July 25, 2019 19:36
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Jul 25, 2019

Hi @toar86 and thanks for the PR.
Since I don't know what behavior must have this module, I need to pIng @marionf @colinegin 😸

@toar86
Copy link
Contributor Author

toar86 commented Jul 27, 2019

For now module only send voucher if you sign in as guest on block on mainsite, but when you register account and check checkbox "Sign up for newsletter", then user don't receive voucher.

@marionf
Copy link
Contributor

marionf commented Jul 29, 2019

@PierreRambaud

@toar86 is right, currently the voucher code is send only if you signup to the newsletter through the newsletter form

capture d'écran_1853

The voucher should be also send when you create a account and check the box "Sign up for our newsletter"

capture d'écran_1854

capture d'écran_1855

@kpodemski
Copy link
Contributor

👍 looking forward for a release of this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants