Improve module Performance #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jun 21, 2022
ghost
commented
| Questions | Answers |
|---|---|
| Description? | The ps_emailsubscription module creates a request to the database on the front of the site, and according to the logic of work, it should only be in the module settings when exporting. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#26696. |
| How to test? | Check export work |
Progi1984
approved these changes
Jun 21, 2022
matthieu-rolland
approved these changes
Jun 21, 2022
NeOMakinG
approved these changes
Jul 4, 2022
florine2623
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
Hello @okom3pom ,
Sorry for the delay.
Tested this fix on PS 1.7.8.x, 8.0.x and develop.
Export works well. Tested with all the different options: Customers' country, Newsletter subscribers and Partner offers accepted.
Export is well downloaded with the right info. Info on alert matches with what's in the export. Edited customer's info, it is well updated in the export.
LGTM, it is QA ✅
jolelievre
approved these changes
Jul 15, 2022
|
Thanks @okom3pom and @florine2623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.