Reindex multistore correctly #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matks
reviewed
May 27, 2019
| @@ -265,8 +265,6 @@ public function indexAttribute($idProduct = null) | |||
| ' . ($idProduct === null ? '' : 'AND pa.id_product = ' . (int) $idProduct) . ' | |||
| GROUP BY a.id_attribute, pa.id_product , product_attribute_shop.`id_shop`' | |||
| ); | |||
|
|
|||
| return 1; | |||
There was a problem hiding this comment.
Should'nt we check the index operation went well (either the database execution return or even a READ SQL query to check data looks good) ?
There was a problem hiding this comment.
hehe, I planned to refactor the installation / upgrade part in the future.
There was a problem hiding this comment.
Easy answer, "Yes I know, I'll do it in another PR" 
matks
approved these changes
May 27, 2019
This was referenced May 31, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests:
This change is