Do not add scheme for empty or anchor links

[JoryHogeveen]

Questions	Answers
Description?	Fixes issue with empty links.
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#27399
How to test?	Create an image slider containing images without URL. Currently the links open a blank page with error. This PR fixes that.

[PierreRambaud]

A little question to be sure :)

[PierreRambaud]

One more approve and I think we can merge :)

[kpodemski]

Hi @JoryHogeveen

In this file:

ps_imageslider/views/templates/hook/slider.tpl

Line 31 in 4824b81

<a href="{$slide.url}">

There's no check if the URL exists or not. I think the point of this PR is to prevent having unused <a> too?

There's no if in the classic too:
https://github.com/PrestaShop/PrestaShop/blob/develop/themes/classic/modules/ps_imageslider/views/templates/hook/slider.tpl#L36

[JoryHogeveen]

Hi @kpodemski

It definitely is somewhat related and on my client's installation I did remove it if there is only an anchor link.
However, in the current plugin the URL of a slider is set as a required field so I'm not sure if this is intended or not.
This PR merely fixes anchor links and isn't really related to whether it should show a link or not.

[florine2623]

Hello @JoryHogeveen ,

Is there an issue related to this PR ?
If yes, you could link ?
If not, could you create it ?

Thanks!

[JoryHogeveen]

@florine2623
Issues are disabled for this repository.

[florine2623]

Hello @JoryHogeveen ,

You can add the issue on the PrestaShop repository : https://github.com/PrestaShop/PrestaShop/issues
The label Imageslider will be added to the issue once reviewed ^^
Thanks!

[JoryHogeveen]

Done: #27399

[florine2623]

Thanks for the update !

Although I'm having an issue after installing the PR :

Could you check ? ^^
Thanks!

[JoryHogeveen]

@florine2623

Such installation issues are unrelated to this PR.
I assume it's an environment issue.

In any case, as you can see in the PR, it merely adds 3 lines of code in a method.

Maybe one of the PS core dev's can help you here.

[kpodemski]

@florine2623

This PR is ready to test.

[florine2623]

Hello @JoryHogeveen ,

Thanks for the PR!
Works like a charm ! QA ✅

[Progi1984]

Thanks @JoryHogeveen & @florine2623