Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed call to api.addons.prestashop.com #166

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Removed call to api.addons.prestashop.com #166

merged 1 commit into from
Apr 6, 2022

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Apr 5, 2022 •
edited
Loading

Questions Answers
Description? Removed call to api.addons.prestashop.com. Now :
The FAQ is now in local :
image
Links to Addons have been removed
image
image
Type? bug fix
BC breaks? yes
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#28027
How to test? Ads are not anymore present and no more calls is done to Addons.

@Progi1984 Progi1984 added the bug Something isn't working label Apr 5, 2022
@Progi1984 Progi1984 added this to the 1.4.1 milestone Apr 5, 2022
@Progi1984 Progi1984 requested a review from a team April 5, 2022 09:21
NeOMakinG
NeOMakinG reviewed Apr 5, 2022
View reviewed changes
views/css/faq.css Outdated Show resolved Hide resolved
@florine2623 florine2623 self-assigned this Apr 6, 2022
florine2623
florine2623 reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore this comment.

After installing the PR, I have an issue in FO :
Screenshot 2022-04-06 at 14 21 41

And in BO > Modules > Configure psgdpr :
Screenshot 2022-04-06 at 14 21 52

Could you check please ?
Thanks!

florine2623
florine2623 reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT : I edited my previous comment as there is no exception on this PR.

Link to addons GDPT whitepaper has been removed ✅
New tab Help has been added for the FAQ.
Screenshot 2022-04-06 at 14 48 37

I have a request, would it be possible to add a space between the icon and the wording for more visibility ?
Screenshot 2022-04-06 at 14 49 28
Also, I changed my Employee Language to French, the FAQ is not updated in French. Could you check ?
Thanks!

@Progi1984
Copy link
Contributor Author

@florine2623 Yes it's normal for translation. It's new wording for the open source project. And just added a space beween icon & title.

florine2623
florine2623 approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful ! Thank you :)
QA ✅

@Progi1984 Progi1984 merged commit 5d67b13 into PrestaShop:dev Apr 6, 2022
@Progi1984 Progi1984 deleted the issue28027 branch April 6, 2022 13:05
@Progi1984
Copy link
Contributor Author

Thanks @florine2623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@florine2623 florine2623 florine2623 approved these changes

Assignees

@florine2623 florine2623

Labels
bug Something isn't working QA ✔️
Projects
None yet
Milestone
1.4.1
4 participants
@Progi1984 @PierreRambaud @NeOMakinG @florine2623