feat: change scandir by symfony finder

[fox-john]

Questions	Answers
Description?	remove all scandir call and use symfony Finder
Type?	improvement
BC breaks?	no
Deprecations?	no
How to test?	Test install / uninstall of module and update to 2.0.0

[lartist]

Several things here. See comments in the code

    //use Symfony\Component\Finder\Finder;
    $finder = (new Finder())
        ->files()
        ->in(dirname(__DIR__) . '/psgdpr/sql/install')
        ->name('*.sql')//We deal only with sql files
    ;

    //This is needed because if $finder->hasResults() return true but the files are empty there will be no query executions
    //and then we should return false
    $hasExecutedAtLeastOneQuery = false;
    //use Symfony\Component\Finder\SplFileInfo
    /** @var SplFileInfo $file */
    foreach ($finder as $file) {
        $contents = $file->getContents();
        //Test first avoid using str_replace needlessly
        if ($contents === '') {
            continue;
        }

        $hasExecutedAtLeastOneQuery = true;
        $query = str_replace('PREFIX_', _DB_PREFIX_, $contents);

        \Db::getInstance()->execute($query);
    }

    return $hasExecutedAtLeastOneQuery;

You can remove the comments

[lartist]

About executeQuerySql method several things. See comments in the code

/** @var EntityManager $entityManager */
        $entityManager = $this->get('doctrine.orm.entity_manager');

        $finder = (new Finder())
            ->files()
            ->in(dirname(__DIR__) . '/psgdpr/sql/' . $folder)
            ->name('*.sql')//We deal only with sql files
        ;

        //This is needed because if $finder->hasResults() return true but the files are empty there will be no query executions
        //and then we should return false
        $hasExecutedAtLeastOneQuery = false;
        /** @var SplFileInfo $file */
        foreach ($finder as $file) {
            $contents = $file->getContents();
            //Test first avoid using str_replace needlessly
            if ($contents === '') {
                continue;
            }

            $hasExecutedAtLeastOneQuery = true;
            $query = str_replace('PREFIX_', _DB_PREFIX_, $contents);


            $entityManager->getConnection()->executeQuery($query);
        }

        $entityManager->flush();//Didn't it work without this line before?

        return $hasExecutedAtLeastOneQuery;

You can remove the comments

[lartist]

I don't understand what are they for?

[fox-john]

It's an oversight, I had put that for my tests. i remove it.

[PrestaPierre]

Hello !
Good for QA

[paulnoelcholot]

Hello @fox-john,

I have tested your PR and it's good for me! 🎉

Thanks!

[nicosomb]

Thank you @fox-john