Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wordings #201

Merged
merged 2 commits into from Apr 5, 2023
Merged

Fix wordings #201

merged 2 commits into from Apr 5, 2023

Conversation

lartist
Copy link
Contributor

@lartist lartist commented Mar 31, 2023

Questions Answers
Description? Fix wordings
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#31935
How to test?

l-delin
l-delin reviewed Mar 31, 2023
View reviewed changes
Copy link

@l-delin l-delin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation domains need to be fixed

psgdpr.php Outdated Show resolved Hide resolved
psgdpr.php Outdated Show resolved Hide resolved
psgdpr.php Outdated Show resolved Hide resolved
psgdpr.php Outdated Show resolved Hide resolved
psgdpr.php Outdated Show resolved Hide resolved
psgdpr.php Outdated Show resolved Hide resolved
psgdpr.php Outdated Show resolved Hide resolved
psgdpr.php Outdated Show resolved Hide resolved
psgdpr.php Outdated Show resolved Hide resolved
psgdpr.php Outdated Show resolved Hide resolved
l-delin
l-delin reviewed Mar 31, 2023
View reviewed changes
psgdpr.php Outdated Show resolved Hide resolved
psgdpr.php Outdated Show resolved Hide resolved
psgdpr.php Outdated Show resolved Hide resolved
@l-delin
Copy link

l-delin commented Mar 31, 2023

Hello again, looks good to me. Thanks :-) wording ✅

@lartist lartist added this to the 2.0.0 milestone Apr 4, 2023
@paulnoelcholot paulnoelcholot self-assigned this Apr 5, 2023
@paulnoelcholot
Copy link

Hello @lartist,

I have tested your PR and it's good for me! 🎉

Thanks!

@paulnoelcholot paulnoelcholot removed their assignment Apr 5, 2023
@lartist
Copy link
Contributor Author

lartist commented Apr 5, 2023

Thanks @lartist :)

@lartist lartist merged commit a813df6 into PrestaShop:dev Apr 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-delin l-delin l-delin left review comments

@nicosomb nicosomb nicosomb approved these changes

@mflasquin mflasquin mflasquin approved these changes

@paulnoelcholot paulnoelcholot paulnoelcholot approved these changes

Assignees
No one assigned
Labels
QA ✔️
Projects
None yet
Milestone
No milestone
6 participants
@lartist @l-delin @paulnoelcholot @nicosomb @mflasquin @jolelievre