Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sha1 deprecation #219

Merged
merged 1 commit into from Sep 26, 2023
Merged

Fix sha1 deprecation #219

merged 1 commit into from Sep 26, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Sep 26, 2023

Questions Answers
Description? Fixes the error message caused by passing null to sha1 method.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#34064
How to test? Setup the module, no deprecated error caused by sha1 method should be displayed next to the checkboxes.

Ping @hibatallahAouadni

@MatShir MatShir added this to the 2.0.3 milestone Sep 26, 2023
boherm
boherm approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@boherm boherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @Hlavtox 😉

@hibatallahAouadni hibatallahAouadni self-assigned this Sep 26, 2023
hibatallahAouadni
hibatallahAouadni approved these changes Sep 26, 2023
View reviewed changes
Copy link

@hibatallahAouadni hibatallahAouadni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox

Thanks for your PR 🙌
Perfect like always ✔️ Tested on 8.1.x and develop and it's Fixed 🚀

image

Thanks

@Hlavtox Hlavtox merged commit 79a4111 into PrestaShop:dev Sep 26, 2023
6 checks passed
@florine2623 florine2623 mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@jolelievre jolelievre jolelievre approved these changes

@boherm boherm boherm approved these changes

@hibatallahAouadni hibatallahAouadni hibatallahAouadni approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

Assignees

@hibatallahAouadni hibatallahAouadni

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
2.0.3
7 participants
@Hlavtox @nicosomb @jolelievre @boherm @hibatallahAouadni @M0rgan01 @MatShir