Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small typo in English dataConsent.tpl #226

Merged
merged 1 commit into from Oct 25, 2023
Merged

Fix small typo in English dataConsent.tpl #226

merged 1 commit into from Oct 25, 2023

Conversation

florine2623
Copy link
Contributor

Questions Answers
Description? Change wording
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? N/A
Sponsor company PS
How to test? Check help text in Consent checkbox customization

Result:

Screenshot 2023-10-24 at 14 59 30

@florine2623 florine2623 mentioned this pull request Oct 24, 2023
Closed
AureRita
AureRita approved these changes Oct 25, 2023
View reviewed changes
Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @florine2623

Thank you for your PR ! I tested it on develop and on 8.1.x, and it works as you can see :

image

it's QA ✔️

Thank you

@nicosomb nicosomb merged commit b7b6f93 into dev Oct 25, 2023
12 checks passed
@nicosomb nicosomb added this to the 2.0.3 milestone Oct 25, 2023
@nicosomb
Copy link
Contributor

Thank you @florine2623 !

@matks matks deleted the fix-typo-in-dataconsent-1 branch March 4, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@mflasquin mflasquin mflasquin approved these changes

@boherm boherm boherm approved these changes

@AureRita AureRita AureRita approved these changes

Assignees
No one assigned
Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
2.0.3
7 participants
@florine2623 @nicosomb @matthieu-rolland @mflasquin @boherm @AureRita @ps-jarvis