Update latvian and russian translations #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zucha
commented
Oct 30, 2023
•
zucha
commented
| Questions | Answers |
|---|---|
| Description? | Added latvian translations to Psgdpr::$presetMessageAccountCreation , replaced russian translation, because it was not correct one. |
| Type? | bug fix & improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | no |
| Sponsor company | |
| How to test? | On checkout page, you need to open manually. If you use Russian language or Latvian language you should see the correct translatations for "I agree to the terms and conditions and the privacy policy" message. |
tleon
reviewed
Oct 31, 2023
|
Sorry, is it ok now? |
matks
approved these changes
Nov 3, 2023
|
I do not have the language skills to validate whether your RU and LV translations are correct however I can tell that, if I use Google Translate, the obtained text is a lot closer to the other translation meanings 😉 |
matks
changed the title
florine2623
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Hello @zucha ,
I don't see the fix with your PR.
I tried to update the module psgdpr, I tried installing the shop in latvian and russian, I updated both languages from the BO.
But I still get the gdpr message in English in the shopping cart and in the customer account area.
Am I missing something ?
boherm
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
thank you @zucha for your PR 👍
lgtm code wise, I let you check @florine2623 's feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.