Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types #28

Closed
wants to merge 3 commits into from
Closed

Add types #28

wants to merge 3 commits into from

Conversation

octref
Copy link
Contributor

@octref octref commented Sep 25, 2018

This makes it easy to consume the node module.
The types is not very complex and I think you can hand-write it when updating the public API.

image

@StarpTech
Copy link
Member

Hi @octref thanks for PR.
One point the "prettier" option is missing in the definition.

@StarpTech
Copy link
Member

@octref your changes were merged with #30 thanks!

@StarpTech StarpTech closed this Sep 29, 2018
@octref
Copy link
Contributor Author

octref commented Sep 29, 2018

Sorry for my late response. I was writing the d.ts following the https://github.com/Prettyhtml/prettyhtml#api illustration. Now you have updated the API, probably also update the readme?

Great work and I'll update my prettyhtml version. Thanks a ton!

@StarpTech
Copy link
Member

Yes, the fix is included in the latest release.

@octref
Copy link
Contributor Author

octref commented Oct 1, 2018

I meant this part. From it I don't know at all about the prettier option.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants