Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SonarCloud fixes #751

Merged
merged 6 commits into from Jul 5, 2019
Merged

SonarCloud fixes #751

merged 6 commits into from Jul 5, 2019

Conversation

rgolubowicz
Copy link
Contributor

@rgolubowicz rgolubowicz added this to the Refactoring milestone Jul 5, 2019
@rgolubowicz rgolubowicz self-assigned this Jul 5, 2019
@rgolubowicz rgolubowicz added this to In progress in Pride in London via automation Jul 5, 2019
@pull-request-size pull-request-size bot added the size/S Helper label Jul 5, 2019
@codecov
Copy link

codecov bot commented Jul 5, 2019 •
edited

Codecov Report

Merging #751 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #751   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files         182      182           
  Lines        1218     1218           
  Branches      145      145           
=======================================
  Hits         1049     1049           
  Misses        130      130           
  Partials       39       39
Impacted Files Coverage Δ
...logDetails/components/blogContent/renderMethods.js 55% <0%> (ø) ⬆️
src/features/genericContentPage/renderMethods.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfff2e9...d38012b. Read the comment docs.

Pride in London automation moved this from In progress to Reviewer approved Jul 5, 2019
@SonyaMoisset SonyaMoisset merged commit 84e1894 into master Jul 5, 2019
Pride in London automation moved this from Reviewer approved to Done Jul 5, 2019
@SonyaMoisset SonyaMoisset deleted the issue/sonarcloud branch July 5, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SonyaMoisset SonyaMoisset SonyaMoisset approved these changes

Assignees

@rgolubowicz rgolubowicz

Labels
Bug Helper Enhancement Helper Refactoring Helper size/S Helper
Projects
Pride in London
  
Done
Milestone
Refactoring
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rgolubowicz @SonyaMoisset