Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivadis guidelines3 plus property file test #3

Conversation

L-K-Primus
Copy link

Merging tests for the new functionality.

Copy link

@S-Koell S-Koell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte noch die Review Kommentare abarbeiten. Sonst sieht es top aus.

@BeforeClass
static def setupValidator() {
static def void setupValidator() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das void kann wieder raus denke ich

Comment on lines 30 to 31
static String propertyPathString = System.getProperty("user.home") + File.separator + "TrivadisGuidelines3Plus.properties"
static String backupPropertyPathString = System.getProperty("user.home") + File.separator + "TrivadisGuidelines3Plus.properties" + ".backup"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dasselbe: Duplicate Code refactor

@@ -21,8 +21,10 @@ class TrivadisGuidelines3PlusPropertyFileTest extends AbstractValidatorTest {

static BufferedWriter bufferedWriter

static String backupAddition = ".backup"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backupAddition -> backupFileSuffix
Dann haben wirs 👍

@S-Koell S-Koell merged commit e44950f into Read_Suffix_or_Prefix_from_File Feb 18, 2020
@L-K-Primus L-K-Primus deleted the TrivadisGuidelines3PlusPropertyFileTest branch February 18, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants