-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trivadis guidelines3 plus property file test #3
Trivadis guidelines3 plus property file test #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bitte noch die Review Kommentare abarbeiten. Sonst sieht es top aus.
src/test/java/com/trivadis/tvdcc/validators/tests/TrivadisGuidelines3PlusPropertyFileTest.xtend
Outdated
Show resolved
Hide resolved
@BeforeClass | ||
static def setupValidator() { | ||
static def void setupValidator() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das void kann wieder raus denke ich
static String propertyPathString = System.getProperty("user.home") + File.separator + "TrivadisGuidelines3Plus.properties" | ||
static String backupPropertyPathString = System.getProperty("user.home") + File.separator + "TrivadisGuidelines3Plus.properties" + ".backup" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dasselbe: Duplicate Code refactor
@@ -21,8 +21,10 @@ class TrivadisGuidelines3PlusPropertyFileTest extends AbstractValidatorTest { | |||
|
|||
static BufferedWriter bufferedWriter | |||
|
|||
static String backupAddition = ".backup" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backupAddition -> backupFileSuffix
Dann haben wirs 👍
Merging tests for the new functionality.