-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image viewer in transcription editor acting improperly #1057
Comments
@rlskoeser both work for me now - I do not lose the zoom bar when I zoom in and the transcription block I selected was not moved around when I zoomed (but this was not an issue for me before). I can close now, or ask Marina to test herself, just to get more eyes on it given how it behaved differently for Rachel and I. |
As Marina was testing (on Vivaldi 5.4, Mac OS Monterray 12.5.1):
|
@richmanrachel Ah, I think I know what happened: the "drag target" for moving annotations from another image was still present after the new annotation was initiated, and caused the editor box to shift down. Thanks to you and Marina for the testing! |
Bump tahqiq commit hash for dropzone (#1057)
@rlskoeser testing with @mrustow today and the editor box was appearing right next to the document as it should, but she had the following issues (see attached video from Marina):
|
Here's the screen recording |
@rlskoeser we tested with Bodleian images and we could move the window around the document when zoomed in but without selecting a text box. Once we created a text box, we could no longer move the window around the document when zoomed in. |
@mrustow the link to your screen recording isn't working, could you share again? Is that problem specific to Bodleian images and not happening on others? If so, then maybe it's a limitation of the static iiif images implementation (which we aren't going to be using, I just haven't removed the initial set of static Bodleian content I loaded). |
@rlskoeser no, we specifically tested with CUDL images first (the video is CUDL image) but the same issue happened with Bodleian https://www.dropbox.com/s/bn4weoprhxlks13/Screen%20Recording%20for%20issue%20%231057.mov?dl=0 |
retesting notes:
Describe the bug
While testing #1000, Ksenia and I ran into different issues with the image on the transcription editor. I had issues of the box I dragged being moved around as I tried to navigate the image (in Google Chrome). Ksenia lost her zoom/rotation bar once she zoomed in (Microsoft Edge, I think?). I am not losing my zoom/rotation bar on Chrome and she did not seem to have issues with navigating around her region box.
To reproduce
Steps to reproduce the behavior:
Expected behavior
Ksenia should have maintained her ability to use the zoom/rotation tool. I should have been able to zoom into the region box and move around to view words as I transcribed them without moving the box itself.
Screenshots
Screenshot from RR where trying to move within a zoomed screen moved the box edge:
[Ksenia's screenshot in #1000]
The text was updated successfully, but these errors were encountered: