Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image viewer in transcription editor acting improperly #1057

Closed
1 task
richmanrachel opened this issue Sep 1, 2022 · 9 comments
Closed
1 task

Image viewer in transcription editor acting improperly #1057

richmanrachel opened this issue Sep 1, 2022 · 9 comments
Assignees
Labels
🛠️ chore One-off task or update

Comments

@richmanrachel
Copy link

richmanrachel commented Sep 1, 2022

retesting notes:

  • confirm the editor box is added next to the top of the image or under the last text section (no empty space above it forcing you to scroll down)

Describe the bug
While testing #1000, Ksenia and I ran into different issues with the image on the transcription editor. I had issues of the box I dragged being moved around as I tried to navigate the image (in Google Chrome). Ksenia lost her zoom/rotation bar once she zoomed in (Microsoft Edge, I think?). I am not losing my zoom/rotation bar on Chrome and she did not seem to have issues with navigating around her region box.

To reproduce
Steps to reproduce the behavior:

  1. Go to test site and "add/edit transcription"
  2. Try to use the region box and the zoom feature
  3. See error

Expected behavior
Ksenia should have maintained her ability to use the zoom/rotation tool. I should have been able to zoom into the region box and move around to view words as I transcribed them without moving the box itself.

Screenshots
Screenshot from RR where trying to move within a zoomed screen moved the box edge:
image
[Ksenia's screenshot in #1000]

@blms blms added 🐛 bug Something isn't working and removed 🐛 bug Something isn't working labels Sep 7, 2022
@blms blms self-assigned this Sep 7, 2022
@rlskoeser rlskoeser added the 🛠️ chore One-off task or update label Sep 8, 2022
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Sep 14, 2022
@kseniaryzhova
Copy link

@rlskoeser both work for me now - I do not lose the zoom bar when I zoom in and the transcription block I selected was not moved around when I zoomed (but this was not an issue for me before). I can close now, or ask Marina to test herself, just to get more eyes on it given how it behaved differently for Rachel and I.

@richmanrachel
Copy link
Author

As Marina was testing (on Vivaldi 5.4, Mac OS Monterray 12.5.1):

  • She did not run into any zoom traps!
  • The shift create a box worked!
  • But when the transcription box was created (at the top of the image), the editor box was a long scroll down from where the selected image section was :(

@blms
Copy link
Contributor

blms commented Sep 20, 2022

@richmanrachel Ah, I think I know what happened: the "drag target" for moving annotations from another image was still present after the new annotation was initiated, and caused the editor box to shift down. Thanks to you and Marina for the testing!

@blms blms added ⚠️ tested needs attention Has been through acceptance testing and needs additional work and removed 🗜️ awaiting testing Implemented and ready to be tested labels Sep 20, 2022
rlskoeser added a commit that referenced this issue Sep 21, 2022
@blms blms added 🗜️ awaiting testing Implemented and ready to be tested and removed ⚠️ tested needs attention Has been through acceptance testing and needs additional work labels Sep 22, 2022
@kseniaryzhova
Copy link

@rlskoeser testing with @mrustow today and the editor box was appearing right next to the document as it should, but she had the following issues (see attached video from Marina):

  • when zoomed in, after zooming out the text box had shifted
  • when zoomed in, Marina could not drag the zoom window to another part of the document

@mrustow
Copy link

mrustow commented Sep 26, 2022

Here's the screen recording

@kseniaryzhova
Copy link

@rlskoeser we tested with Bodleian images and we could move the window around the document when zoomed in but without selecting a text box. Once we created a text box, we could no longer move the window around the document when zoomed in.

@rlskoeser
Copy link
Contributor

@mrustow the link to your screen recording isn't working, could you share again?

Is that problem specific to Bodleian images and not happening on others? If so, then maybe it's a limitation of the static iiif images implementation (which we aren't going to be using, I just haven't removed the initial set of static Bodleian content I loaded).

@kseniaryzhova
Copy link

@rlskoeser no, we specifically tested with CUDL images first (the video is CUDL image) but the same issue happened with Bodleian https://www.dropbox.com/s/bn4weoprhxlks13/Screen%20Recording%20for%20issue%20%231057.mov?dl=0

@blms
Copy link
Contributor

blms commented Sep 27, 2022

Based on meeting discussion, closing this as acceptable behavior that passes testing.

Remaining work is in #1129 (an unrelated issue with the editor) and #1131 (help text to clarify behavior noted above).

@blms blms closed this as completed Sep 27, 2022
@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update
Projects
None yet
Development

No branches or pull requests

5 participants