Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional help text to transcription editor #1131

Closed
6 tasks done
blms opened this issue Sep 27, 2022 · 4 comments
Closed
6 tasks done

Add additional help text to transcription editor #1131

blms opened this issue Sep 27, 2022 · 4 comments
Assignees
Labels
🛠️ chore One-off task or update

Comments

@blms
Copy link
Contributor

blms commented Sep 27, 2022

testing notes (qa)

Edit the transcription for a document (via document details page --> "edit x's edition" or "add new")

  • Read the help text in the transcription editor, and confirm it is left-aligned, makes sense, and is accurate
  • Confirm the new text is present

dev notes

  • add instructions that you have to click outside the bounding box to pan
    • adjust tahqiq logic so this works with unsaved annotations!
  • add instructions about dragging to reorder or move to a different image
  • align help text left
@blms blms added the 🛠️ chore One-off task or update label Sep 27, 2022
@blms blms self-assigned this Sep 27, 2022
blms added a commit that referenced this issue Sep 28, 2022
blms added a commit that referenced this issue Sep 28, 2022
Co-authored-by: Rebecca Sutton Koeser <rlskoeser@users.noreply.github.com>
blms added a commit that referenced this issue Sep 28, 2022
Co-authored-by: Rebecca Sutton Koeser <rlskoeser@users.noreply.github.com>
blms added a commit that referenced this issue Sep 28, 2022
Update editor help text and add navigator to OSD (#1131, #1132)
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Sep 28, 2022
@kseniaryzhova
Copy link

@rlskoeser @blms Given our update on using the thumbnail to move around the document image when Zoomed in, could we update the help text to say the following (changes in bold):
"Hold shift and then click and drag over the image to select a rectangular region for the block of text you want to transcribe (this is an annotation zone).
When an annotation zone is active on the image, use the red square in the thumbnail to move around the image when zoomed in.
Drag blocks of text to reorder or move to a different image."

Otherwise, the text is left-aligned!

@blms blms added ⚠️ tested needs attention Has been through acceptance testing and needs additional work and removed 🗜️ awaiting testing Implemented and ready to be tested labels Sep 29, 2022
@blms blms removed the ⚠️ tested needs attention Has been through acceptance testing and needs additional work label Oct 4, 2022
rlskoeser added a commit that referenced this issue Oct 5, 2022
@blms blms added the 🗜️ awaiting testing Implemented and ready to be tested label Oct 5, 2022
@kseniaryzhova
Copy link

@rlskoeser @blms works for me! Only thing is a minor aesthetic annoyance - on my screen the second sentence is too long and the "in" at the end is on its own line - looks awkward. If it's an easy fix, can we break up the sentence so that 2+ words are on the next line?

@blms
Copy link
Contributor Author

blms commented Oct 5, 2022

@kseniaryzhova This depends on the size of your window—if you resize the window, the text wraps differently. Do we need this to be consistent regardless of window size? (Keep in mind this is also only seen by transcription editors, it's not public)

If it's ok like this, and that's the only remaining issue, then we can go ahead and close I think!

@rlskoeser
Copy link
Contributor

I don't think we need to override the line wrapping, and css doesn't allow for widow/orphan controls with text wrapping, so let's leave this.

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update
Projects
None yet
Development

No branches or pull requests

3 participants