Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

about menu id is duplicated — same id used in both header and footer nav (ids must be unique) #1088

Closed
Tracked by #1087
rlskoeser opened this issue Sep 15, 2022 · 1 comment
Closed
Tracked by #1087

about menu id is duplicated — same id used in both header and footer nav (ids must be unique) #1088

rlskoeser opened this issue Sep 15, 2022 · 1 comment
Assignees
@blms
Labels
♿ accessibility Impacts access for some users 🛠️ chore One-off task or update
Milestone
Transcription mig...

Comments

@rlskoeser
Copy link
Contributor

No description provided.

@rlskoeser rlskoeser mentioned this issue Sep 15, 2022
Closed
6 tasks
@rlskoeser rlskoeser added the 🛠️ chore One-off task or update label Sep 15, 2022
@blms blms self-assigned this Sep 15, 2022
@rlskoeser rlskoeser added the ♿ accessibility Impacts access for some users label Sep 15, 2022
@rlskoeser rlskoeser added this to the CDH/PGP end of grant year 2 milestone Sep 19, 2022
blms added a commit that referenced this issue Sep 19, 2022
@blms
Prepend footer- to footer menu IDs (#1088)
2d71157
@blms blms mentioned this issue Sep 19, 2022
Merged
rlskoeser added a commit that referenced this issue Sep 21, 2022
@rlskoeser
Merge pull request #1104 from Princeton-CDH/feature/1088-about-id-footer
d1bb39d 
Fix duplicate menu IDs (#1088)
@rlskoeser
Copy link
Contributor Author

confirmed fixed on test site by scanning with axe DevTools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blms blms

Labels
♿ accessibility Impacts access for some users 🛠️ chore One-off task or update
Projects
None yet
Milestone
Transcription migration + transcripti...
Development

No branches or pull requests
2 participants
@rlskoeser @blms