accessibility issues flagged by DubBot

[rlskoeser]

• view document details link on search results needs aria label: view details for [title] (multiple links with same name)
• about menu id is duplicated — same id used in both header and footer nav (ids must be unique) #1088
• add aria label "permalink" to permalink on document details (url as text of link)
• remediate sort selection drop-down: interactive controls must not be nested #1089
• pagination nav sections: landmark must have a unique aria-label, aria-labelledby, or title
• light/dark mode toggle is not inside a landmark (all page content should be contained by landmarks) #1090

[rlskoeser]

We've closed all the tasks listed in this issue; I'll go ahead and close this one and we can create more issues as we discover problems

[rlskoeser]

ah, the issues were checked off but I forgot that was for implementation and many of the changes are still in the PR that is causing a lighthouse error; re-opening this to remind myself to revisit — want to try cherry-picking fixes into a new branch one at a time so I can figure out what's breaking the lighthouse check

[richmanrachel]

@rlskoeser - should this be closed now or are there issues we need to keep on our radar?

[rlskoeser]

I probably never circled back to close it after the sub-tasks were completed, thanks for reminding me. Let's close it.

[rlskoeser]

reopening since the changes were made but never merged due to a failing lighthouse check; changes are in #1116 and have been updated to patch against latest version of develop branch; can be merged as soon as we resolve the lighthouse check

[blms]

Lighthouse check resolved, closing!