Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

light/dark mode toggle is not inside a landmark (all page content should be contained by landmarks) #1090

Closed
Tracked by #1087
rlskoeser opened this issue Sep 15, 2022 · 1 comment
Closed
Tracked by #1087

light/dark mode toggle is not inside a landmark (all page content should be contained by landmarks) #1090

rlskoeser opened this issue Sep 15, 2022 · 1 comment
Assignees
@blms
Labels
♿ accessibility Impacts access for some users 🛠️ chore One-off task or update
Milestone
Transcription mig...

Comments

@rlskoeser
Copy link
Contributor

No description provided.

@rlskoeser rlskoeser mentioned this issue Sep 15, 2022
Closed
6 tasks
@rlskoeser rlskoeser added 🛠️ chore One-off task or update ♿ accessibility Impacts access for some users labels Sep 15, 2022
@rlskoeser rlskoeser changed the title dark mode toggle is not inside a landmark (all page content should be contained by landmarks) light/dark mode toggle is not inside a landmark (all page content should be contained by landmarks) Sep 15, 2022
@rlskoeser rlskoeser added this to the CDH/PGP end of grant year 2 milestone Sep 19, 2022
blms added a commit that referenced this issue Sep 19, 2022
@blms
Move nav outside, and theme toggle inside, header
3ee7ad6 
ref #1090
@blms blms mentioned this issue Sep 19, 2022
Merged
blms added a commit that referenced this issue Sep 19, 2022
@blms
Fix z-index for theme toggle on mobile (#1090)
b9daa37
rlskoeser added a commit that referenced this issue Sep 21, 2022
@rlskoeser
Merge pull request #1105 from Princeton-CDH/feature/1090-themetoggle-…
0b28fc5 
…landmark

Move nav outside, and theme toggle inside, header (#1090)
@rlskoeser
Copy link
Contributor Author

confirmed fixed on test site by scanning with axe DevTools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blms blms

Labels
♿ accessibility Impacts access for some users 🛠️ chore One-off task or update
Projects
None yet
Milestone
Transcription migration + transcripti...
Development

No branches or pull requests
2 participants
@rlskoeser @blms