Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the placement and size of the open panel on mobile relative to the selected leaf label #52

Closed
gissoo opened this issue Jan 25, 2023 · 2 comments
Assignees
Labels
🛠️ chore One-off task or update

Comments

@gissoo
Copy link
Contributor

gissoo commented Jan 25, 2023

No description provided.

@rlskoeser
Copy link
Contributor

we know we need to revisit this, but depends on other layout decisions; putting in the icebox for now

@gissoo gissoo changed the title Fix the placement and size of the open panel on mobile with relative to the selected leaf label Fix the placement and size of the open panel on mobile relative to the selected leaf label Feb 6, 2023
rlskoeser added a commit that referenced this issue Mar 28, 2023
Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com>
rlskoeser added a commit that referenced this issue Apr 4, 2023
* Adjust panel size and placement on mobile #52

Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com>

* Fix debug control panel positioning

* Update colors for header/footer/panel and add panel box shadow #125

* Add phosphor icons; adjust panel styles and close button position

* Revise panel styles

- more semantic names for panel content sections
- close button positioning/styling #84
- split out panel styles into a component csss file
- make close button more accessible

* Add leaf icon to branch in leaf details

* Fix selected leaf hash bug

* Update unit tests for changes to container names

* Update visual testing selected leaf id, run in production mode

* Fix icon mask size on chrome; set max height for panel on desktop

* Adjust panel height and tree top margin on mobile

Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com>

* Revise panel styles and adjust layout

* Add label to placeholder tag so it won't cause lighthouse ci to fail

* Add overflow wrapping within panel text

---------

Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com>
@rlskoeser
Copy link
Contributor

included in #130

@rlskoeser rlskoeser added the 🛠️ chore One-off task or update label Apr 10, 2023
rlskoeser added a commit that referenced this issue Sep 22, 2023
* Adjust panel size and placement on mobile #52

Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com>

* Fix debug control panel positioning

* Update colors for header/footer/panel and add panel box shadow #125

* Add phosphor icons; adjust panel styles and close button position

* Revise panel styles

- more semantic names for panel content sections
- close button positioning/styling #84
- split out panel styles into a component csss file
- make close button more accessible

* Add leaf icon to branch in leaf details

* Fix selected leaf hash bug

* Update unit tests for changes to container names

* Update visual testing selected leaf id, run in production mode

* Fix icon mask size on chrome; set max height for panel on desktop

* Adjust panel height and tree top margin on mobile

Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com>

* Revise panel styles and adjust layout

* Add label to placeholder tag so it won't cause lighthouse ci to fail

* Add overflow wrapping within panel text

---------

Co-authored-by: Gissoo <44615389+gissoo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update
Projects
None yet
Development

No branches or pull requests

2 participants