MDF compatibility #2154
Merged
MDF compatibility #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
retest this please |
|
This pull request introduces 7 alerts when merging ca660bd into 1373206 - view on LGTM.com new alerts:
|
|
retest this please |
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This pull request introduces 2 alerts when merging a37b1ef into 1373206 - view on LGTM.com new alerts:
|
|
modeci_mdf still has graph-scheduler pinned to 1.0.0rc2, which is causing the documentation differences. |
jvesely
reviewed
Oct 30, 2021
.github/workflows/pnl-ci.yml
Outdated
| fetch-depth: 200 | ||
|
|
||
| - name: Checkout tags | ||
| run: git fetch --tags |
There was a problem hiding this comment.
why does this need to fetch tags, or deeper history?
jvesely
reviewed
Oct 30, 2021
.github/workflows/pnl-ci-docs.yml
Outdated
| ref: ${{ github.base_ref }} | ||
|
|
||
| - name: Checkout tags | ||
| run: git fetch --tags |
There was a problem hiding this comment.
I'm not sure I understand the goal here.
The main docs page is built on tag events so it already has the correct tag/version,
the branch docs are currently identified with as e.g. "0+untagged.11.gaabca55".
Is the idea here to to have instead something like "v0.9.1.1-67-gaabca55987" ?
the identifying part (short git hash) is the same.
There was a problem hiding this comment.
Yes exactly, modeci_mdf depends on a specific psyneulink version, and if the local version of psyneulink is untagged, the installation will fail (example). I think this is due to the more restrictive dependency checks in pip 20.3.
If the repo doesn't have older tags and a history from the current commit to one of those tags (reason for fetch-depth change above), versioneer will leave the version as untagged[...]
There was a problem hiding this comment.
ah, that explains it, thanks! Can you add a short comment around tag fetching step?
so modeci_mdf has circular dependency on pnl?
There was a problem hiding this comment.
Sure, I will, and yes modeci_mdf depends on psyneulink as well
kmantel
force-pushed
the
mdf
branch
2 times, most recently
from
d4c9936
to
333495e
Compare
|
Supports:
|
|
This pull request introduces 1 alert when merging 333495e into 7b93c36 - view on LGTM.com new alerts:
|
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
kmantel
force-pushed
the
mdf
branch
3 times, most recently
from
4321521
to
239b154
Compare
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
actual differences in results were suppressed if numpy == comparison fails
add as_mdf_model method where _dict_summary currently existed, replace use of _dict_summary. _dict_summary is not deleted due to current lack of support for nested Graphs in MDF (TBD if support for this is desired) requirements: include modeci_mdf package at <0.3.2 tests: add tests for MDF results equivalence Parameters: add mdf_name entry
modeci_mdf is not supported on 32-bit python because of onnxruntime, but some psyneulink functionality is tested and should still be able to run
if functions share names with nodes or graphs, they'll be treated as references to the node or graph instead.
tests: JSON: add multiple incoming projections example
JSON: functions: add initializers as stateful parameters tests: add integrator tests
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for most of MDF v0.3.1, includes
mathfunctions, MDF library functions, string expressions asUserDefinedFunctionsdoes not include
GHA workflow changes:
psyneulinkversion is detected formodeci_mdfcross-dependencyNew requirements
modeci_mdf(excluded in x86 builds)