-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/comp/mult proj between nodes #2251
Conversation
…Link into refactor/ocm/state_input_ports
…ut_ports # Conflicts: # psyneulink/core/components/mechanisms/modulatory/control/optimizationcontrolmechanism.py
- __init__: moved controller instantiation until after nodes, projections and pathways
- __init__: restored add_controller position
…teger Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
…ut_ports # Conflicts: # psyneulink/core/llvm/builder_context.py
…Link into refactor/ocm/state_input_ports
- _update_controller: added - add_controller and _analyze_graph(): call _update_controller
_update_controller: fixed to loop through all input_ports of comp INPUT nodes
- test_agent_rep_assignement_as_controller_and_replacement: updated to test that shadowing projections to state_input_ports are properly added and deleted
…Link into refactor/ocm/state_input_ports � Conflicts: � tests/composition/test_control.py
- _function: refactored to put use aggregation_function at end - _grid_evaluate: still needs to return all_samples
…rincetonUniversity/PsyNeuLink into refactor/ocm/state_input_ports � Conflicts: � psyneulink/core/components/mechanisms/modulatory/control/optimizationcontrolmechanism.py
- added call to _update_controller to add_node - moved test for projections to controller.state_input_ports to run()
…Link into refactor/ocm/state_input_ports
moved calls to _update_controller to _complete_init_of_partially_initialized_nodes moved _update_controller to ocm._update_state_input_ports • optimizationcontrolmechanism.py: added _update_state_input_ports [**still needed work**]
moved calls to _update_controller to _complete_init_of_partially_initialized_nodes moved _update_controller to ocm._update_state_input_ports _instantiate_controller_shadow_projections [still needs to be implemented] • optimizationcontrolmechanism.py: added _update_state_input_ports [**still needed work**]
…rincetonUniversity/PsyNeuLink into refactor/ocm/state_input_ports
added needs_update_controller
- implemented self.needs_update_controller - moved implementation of controlsignal projections from add_controller to _instantiate_control_projections that is called in _complete_init_of_partially_initialized_nodes Note: still need to set self.needs_update_controller to False after instantiating state_input_ports and projections to them
add_projection: working on adding support for projection sets
- add _get_nested_nodes_with_same_roles_at_all_levels - add_linear_processing_pathway: call _get_nested_nodes_with_same_roles_at_all_levels
- add_linear_processing_pathway: add support for inline specification of set of Projections
add_linear_processing_pathway: refactored to support inline specification of sets of Projections
add_linear_processing_pathway: docstring edits for Projection set specification
…m/PrincetonUniversity/PsyNeuLink into feat/comp/mult_proj_between_nodes � Conflicts: � psyneulink/core/compositions/composition.py
…m/PrincetonUniversity/PsyNeuLink into feat/comp/mult_proj_between_nodes
- add test_add_multiple_projections_for_nested_compositions - IN PROGRESS
…m/PrincetonUniversity/PsyNeuLink into feat/comp/mult_proj_between_nodes
- add test_add_multiple_projections_for_nested_compositions - passes
…Link into feat/comp/mult_proj_between_nodes
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
1 similar comment
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
This pull request introduces 1 alert when merging 7a0542e into 7c2d3cf - view on LGTM.com new alerts:
|
• composition.py
_add_linear_processing_pathway, add_projection, _is_pathway_entry_spec:
- support lists or sets of Projections between Nodes of nested Compositions in a Pathway
- support automatic specification of many->one and one->many projections between mech and comps in pathway spec
- test_composition/test_add_multiple_projections_for_nested_compositions tests for these features
• show_graph.py
_assign_cim_components(): fix bug in which comp1_output_cim->comp2_input_cim was skipped and not shown