Qt6 migration #288
Merged
Qt6 migration #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ParkerK , thanks for your help :-) I was a little bit busy last few weeks ( pre-vacation routine ), but now I can take a look at the changes and prepare to the release. |
|
@Elkin-Vasily , Looks like we need to change also min Cura version since this patch, because we have breaking changes for Cura 4.* , don't we? |
Jeredian
added
the
pull request: community
Jeredian
requested changes
May 11, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
ParkerK
commented
May 12, 2022
Jeredian
approved these changes
May 13, 2022
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the code to work for Qt6, which Cura 5 now uses (Issue #287 ). The imports were changed, and some of the QT types were changed (ex
Cura.CheckBoxis nowUM.CheckBox).I was able to get it running and working in Cura 5 as a result. I hope it can save you some time and trouble :)
I have not fully tested everything, but I hope this will be a useful starting point