Qt6 migration - pt2 #292
Qt6 migration - pt2 #292
Conversation
I thought I saw another plugin that had somehow managed to put the legacy (<5.0) code in a new directory for backward compatibility, I will see if I can find it |
qml/MKSConnectBtn.qml
Outdated
| @@ -61,7 +61,7 @@ Item { | |||
| onClicked: Cura.MachineManager.printerOutputDevices[0].requestAuthentication(); | |||
| // style: UM.Theme.styles.print_setup_action_button; | |||
| text: catalog.i18nc("@action:button", "Request Access"); | |||
| tooltip: catalog.i18nc("@info:tooltip", "Send access request to the printer"); | |||
| // tooltip: catalog.i18nc("@info:tooltip", "Send access request to the printer"); | |||
There was a problem hiding this comment.
Can we keep somehow tooltip usage, or it's deprecated in new release?
There was a problem hiding this comment.
This is something I'm still trying to figure out. I know that attempting to use the tooltip property for Qt's Button will cause an error, as it's been removed. It might still be in Cura.PrimaryButton or another ButtonType? If not, I think it can be added via a onHover method or something. I've just commented them out for now so the plugin will load in Cura 5.0, but it certainly should be addressed
There was a problem hiding this comment.
Found it. https://doc-snapshots.qt.io/qt6-dev/qml-qtquick-controls2-tooltip.html#details
I will update all tooltips accordingly :)
|
Found it https://github.com/emtrax-ltd/Cura2MoonrakerPlugin seems to be able to handle Qt5 and 6 in the same package. I didn't look too much into it yet though. Same with https://github.com/fieldOfView/Cura-OctoPrintPlugin Also, I just wanted to thank you for letting me help out with this, I use the plugin daily, so I'm just happy I'm able to give back :) |
|
Kudos, SonarCloud Quality Gate passed!
|
Jeredian
added
the
pull request: community
A few more changes to make this qt6 compatible, this fixes the 'Monitor' tab for Cura 5.0
For #287