Skip to content
This repository has been archived by the owner on Jan 24, 2018. It is now read-only.

Plugin system #14

Closed
Prinzhorn opened this issue May 4, 2012 · 2 comments
Closed

Plugin system #14

Prinzhorn opened this issue May 4, 2012 · 2 comments
Assignees

Comments

@Prinzhorn
Copy link
Owner

I'm thinking about dropping hsl support from skrollr core, because it's only needed for IE < 9 (and some very old Firefox etc.). I'd drop the IE "filter" stuff at the same time.

Instead of having those in core, it would available be as a plugin which transforms hsl to hex on the fly. This change could make skrollr core close to 5k small.

How plugins could work or how the api could look like: Allow plugins to hook into the setStyle method. This would allow transforming hsl as well as adding the IE filter style. Other entry points for plugins could later be specified.

Well, actually I'm not thinking about this, I will just do it.

@ghost ghost assigned Prinzhorn May 4, 2012
@karbassi
Copy link
Contributor

karbassi commented May 4, 2012

+1

@Prinzhorn
Copy link
Owner Author

Check out branch "better-parser" for progress on this and #13. https://github.com/Prinzhorn/skrollr/tree/better-parser
IE plugin: https://github.com/Prinzhorn/skrollr/blob/better-parser/plugins/skrollr.ie.js

skrollr core is now at 5.3k (from 7.5k).

Prinzhorn pushed a commit that referenced this issue May 5, 2012
Better parser and plugin system. Fixes #13 and #14 as well.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants