Nested script inside jsx tag is not parsed

[supnate]

<CodeView title={<span title={123}>2</span>}>for of as</CodeView>

[Golmote]

Hi! Thanks for reporting.
I don't think we're gonna fix this one, though. Prism can't (at the moment anyway) handle infinitely deep recursions of patterns.

We might handle it at some point, but this is really not on agenda for the near future.

[supnate]

That's fine. Thanks.

[Golmote]

I reopen this issue, since it should actually be fixable.

[supnate]

Thanks @Golmote ! Can't wait to try it!

[supnate]

By the way, just for your information, I'm using prismjs for syntax highlighting with Monaco Editor. See the live demo at: http://demo.rekit.org/element/src%2Ffeatures%2Fcommon%2Fmonaco%2Fworkers%2FsyntaxHighlighter.js/code . Did some job on finding jsx text elements.

[Golmote]

I accidently closed the issue when #1345 was merged. But it was actually fixed in the next commit (cc80ccd). A test for this specific use case was added in f0e6249.

So it should be fixed now! 🎉

Note that we probably still won't be able to handle infinite recursion (since JS regexps are not recursive), but at least this use case is handled!

[Golmote]

By the way, just for your information, I'm using prismjs for syntax highlighting with Monaco Editor. See the live demo at: http://demo.rekit.org/element/src%2Ffeatures%2Fcommon%2Fmonaco%2Fworkers%2FsyntaxHighlighter.js/code . Did some job on finding jsx text elements.

You mean to handle plain text (#1304 and #1294)? That's interesting! Unfortunately, this looks too complicated to be included in Prism like this... I'd love to find a lighter solution to this issue.

[supnate]

Yes exactly! Both for the problem and code complication.. Hope it would be resolved from prismjs side finally some day!

Thanks for your effort on making such a great tool!