Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSX: Bug highlighting plain text inside JSX tags #1294

Closed
m-allanson opened this issue Feb 13, 2018 · 4 comments
Closed

JSX: Bug highlighting plain text inside JSX tags #1294

m-allanson opened this issue Feb 13, 2018 · 4 comments
Labels
enhancement language-definitions

Comments

@m-allanson
Copy link

Hi, PrismJS is working really nicely over on gatsbyjs.org, thanks!

It looks like there a bug where some text between JSX tags will be incorrectly highlighted, e.g. <H1>do, of and as will be highlighted here</H1>

Here's a Test Drive screenshot:

screen shot 2018-02-13 at 12 40 47

Ref: gatsbyjs/gatsby#4002
@Golmote
Copy link
Contributor

Golmote commented Feb 14, 2018

Hi! Thanks for reporting.
What do you think @vkbansal? Can we fix or improve plain text support in JSX markup tags?

@mAAdhaTTah
Copy link
Member

FWIW, Atom's JSX highlighting seems to have this bug as well, so this may be a tough one to fix.

@Golmote Golmote mentioned this issue Feb 21, 2018
Closed
This was referenced Mar 13, 2018
Closed
Merged
@Golmote
Copy link
Contributor

Golmote commented Mar 20, 2018

Fixed in PR #1357! 🎉

@Golmote Golmote closed this as completed Mar 20, 2018
@m-allanson
Copy link
Author

Great stuff, thanks @Golmote!

@fk fk mentioned this issue Sep 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement language-definitions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m-allanson @Golmote @mAAdhaTTah