New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F# computation expressions are not highlighted #1459

Closed

mikhailshilkov opened this issue Jul 3, 2018 · 4 comments · Fixed by #1573

Labels

enhancement good first issue language-definitions

mikhailshilkov commented Jul 3, 2018

F# computation expressions are not highlighted (async in this example):

Desired result (VS Code screenshot):

The text was updated successfully, but these errors were encountered:

mAAdhaTTah added bug language-definitions good first issue labels

Member

mAAdhaTTah commented Jul 3, 2018

I think for this one, just adding async as a keyword in F# should suffice. I don't think I would highlight the {} the way VSCode does.

Author

mikhailshilkov commented Jul 3, 2018

It would help for async, but that can actually be any literal:

Member

mAAdhaTTah commented Jul 3, 2018 •

edited

Loading

What other keywords can go there? I'm not entirely sure we can handle this in a generic way with regexes.

To put it more generically, what's the grammar for computation expressions?

Author

mikhailshilkov commented Jul 3, 2018

I can be any valid F# literal, because they are also user-defined.

Interestingly, VS Code does hightlight async, task, seq and maybe, but doesn't highlight some others.

Visual Studio highlights anything:

Golmote added enhancement and removed bug labels

RunDevelopment mentioned this issue

F# improvements #1573

Merged

mAAdhaTTah closed this as completed in #1573

mAAdhaTTah pushed a commit that referenced this issue


          Improve F# (#1573)

00bfc96

Implement a few F# features:

1. [Attributes](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/attributes).
2. [Computation expressions](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/computation-expressions) (resolves #1459).
3. Class names for type annotations, [casts ](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/casting-and-conversions)(not including `as`), definitions and instancing (resolves #1460).
4. Proper support for ([nullable](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/symbol-and-operator-reference/nullable-operators)) [operators](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/symbol-and-operator-reference/).

ggrossetie pushed a commit to ggrossetie/prism that referenced this issue


          Improve F# (PrismJS#1573)

af290f3

Implement a few F# features:

1. [Attributes](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/attributes).
2. [Computation expressions](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/computation-expressions) (resolves PrismJS#1459).
3. Class names for type annotations, [casts ](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/casting-and-conversions)(not including `as`), definitions and instancing (resolves PrismJS#1460).
4. Proper support for ([nullable](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/symbol-and-operator-reference/nullable-operators)) [operators](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/symbol-and-operator-reference/).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment