F# improvements #1573
Merged
F# improvements #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
reviewed
Dec 1, 2018
| private public rec return | ||
| return! select static struct | ||
| then to true try type | ||
| then to true try type; |
There was a problem hiding this comment.
Curious about these semicolons here. Are they syntactically correct for F#?
There was a problem hiding this comment.
To rephrase, were the old code snippets wrong?
There was a problem hiding this comment.
That's because after type, inherit, etc. follow class names.
If that semicolon isn't there, the next keyword will be highlighted as a class name.
There was a problem hiding this comment.
Worth adding a test that demonstrates this? Or do we have one for that?
There was a problem hiding this comment.
Sure we have! class-name_feature.test
ggrossetie
pushed a commit
to ggrossetie/prism
that referenced
this pull request
Mar 11, 2019
Implement a few F# features: 1. [Attributes](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/attributes). 2. [Computation expressions](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/computation-expressions) (resolves PrismJS#1459). 3. Class names for type annotations, [casts ](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/casting-and-conversions)(not including `as`), definitions and instancing (resolves PrismJS#1460). 4. Proper support for ([nullable](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/symbol-and-operator-reference/nullable-operators)) [operators](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/symbol-and-operator-reference/).
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a few F# features:
as), definitions and instancing (resolves F# type annotations are not highlighted #1460).Example
See for yourself!