Python: Decorator support #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sardmhmd
reviewed
Nov 30, 2018
|
You need to leave a comment indicating the requested changes. |
mAAdhaTTah
reviewed
Dec 1, 2018
| @@ -0,0 +1,28 @@ | |||
| @some.decorator(foobar) | |||
There was a problem hiding this comment.
Do we want to highlight the whole line as a decorator or just the @ symbol? How do other highlighters do it?
There was a problem hiding this comment.
I err towards highlighting @some.decorator as Notepad++ and VS both do.
(VS Code doesn't highlight anything)
|
Wow that was quick. |
ggrossetie
pushed a commit
to ggrossetie/prism
that referenced
this pull request
Mar 11, 2019
Add support for Python decorators, implementing PrismJS#1635 using the solution proposed by @spectras. Also add 2 aliases: `annotation` to be like Java and `punctuation` to change the actual color (like Java). This resolves PrismJS#1635.
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Python decorators implementing #1635 using the solution proposed by @spectras.
I also added 2 aliases:
annotationto be like Java andpunctuationto change the actual color (like Java).This resolves #1635.