fix(core): Don’t redefine clone variable

[ExE-Boss]

This shows up when setting

"javascript.implicitProjectConfig.checkJs": true

in VS Code’s settings.json.

This also makes the minified files slightly smaller, as the clone variable is defined only in one place, instead of two:

Before:

clone:function i(e,t){var r=a.util.type(e);switch(t=t||{},r){
case"Object":var n=a.util.objId(e);if(t[n])return t[n];var l={};t[n]=l;for(var o in e)e.hasOwnProperty(o)&&(l[o]=i(e[o],t));return l;
case"Array":var n=a.util.objId(e);if(t[n])return t[n];var l=[];return t[n]=l,e.forEach(function(e,a){l[a]=i(e,t)}),l}
/*default:*/return e}}

After:

clone:function i(e,t){var n,r,l=a.util.type(e);switch(t=t||{},l){
case"Object":if(r=a.util.objId(e),t[r])return t[r];n={},t[r]=n;for(var o in e)e.hasOwnProperty(o)&&(n[o]=i(e[o],t));return n;
case"Array":return r=a.util.objId(e),t[r]?t[r]:(n=[],t[r]=n,e.forEach(function(e,a){n[a]=i(e,t)}),n)}
/*default:*/return e}}

After a17303c:

clone:function i(e,t){var n,r,l=a.util.type(e);switch(t=t||{},l){
case"Object":if(r=a.util.objId(e),t[r])return t[r];n={},t[r]=n;for(var o in e)e.hasOwnProperty(o)&&(n[o]=i(e[o],t));return n;
case"Array":return r=a.util.objId(e),t[r]?t[r]:(n=[],t[r]=n,e.forEach(function(e,a){n[a]=i(e,t)}),n);
default:return e}}}

[RunDevelopment]

Shouldn't you get the same warning for id as well? Because I do.

Edit: My bad, that was SonarLint. But it's still the same for id.

[ExE-Boss]

Right, id is string, so the default TypeScript configuration doesn’t complain.

[RunDevelopment]

Ahh, so it complained because of the different types. SonarLint complains because the variable id is redeclared in the same (function) scope.

It would be nice to fix that as well.

[ExE-Boss]

Results:

• Without a17303c: 16 bytes saved.
• With a17303c: 8 bytes saved.

[RunDevelopment]

I think the gained readability (it just looks cleaner IMO) is more important.

And then again: It's only 8 bytes.

[RunDevelopment]

Thank you for contributing!